Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Organize network module #391

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

helayoty
Copy link
Member

No description provided.

@helayoty helayoty temporarily deployed to test December 14, 2022 01:21 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 01:22 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 18:24 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 18:24 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 19:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 19:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 21:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 21:52 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 22:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 14, 2022 22:04 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 19, 2022 21:38 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 19, 2022 21:38 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 19, 2022 21:42 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 19, 2022 21:42 — with GitHub Actions Inactive
pkg/network/aci_network.go Outdated Show resolved Hide resolved
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test December 20, 2022 01:12 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 01:12 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #391 (13d74fe) into master (3e3e107) will increase coverage by 0.69%.
The diff coverage is 22.50%.

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   42.25%   42.94%   +0.69%     
==========================================
  Files          51       50       -1     
  Lines        5737     5717      -20     
==========================================
+ Hits         2424     2455      +31     
+ Misses       3056     3005      -51     
  Partials      257      257              
Impacted Files Coverage Δ
pkg/provider/config.go 68.29% <0.00%> (ø)
pkg/provider/aci.go 33.81% <19.44%> (-0.94%) ⬇️
pkg/network/aci_network.go 26.94% <23.80%> (ø)
pkg/provider/containergroup_to_pod.go 77.84% <100.00%> (ø)
pkg/util/aci_utils.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty merged commit c161a85 into virtual-kubelet:master Dec 20, 2022
@helayoty helayoty deleted the organize-network-module branch December 20, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants