Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip IPAddress check for windows containers #379

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: Skip IPAddress check for windows containers #379

merged 1 commit into from
Dec 20, 2022

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Dec 1, 2022 •
edited
Loading

Fixes: #377 & #378
Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

@helayoty helayoty added the kind/bug Something isn't working label Dec 1, 2022
@helayoty helayoty temporarily deployed to test December 1, 2022 20:16 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 20:16 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:02 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:03 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:26 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:27 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:44 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:44 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:47 Inactive
@helayoty helayoty temporarily deployed to test December 1, 2022 21:47 Inactive
@helayoty helayoty temporarily deployed to test December 3, 2022 03:25 Inactive
@helayoty helayoty temporarily deployed to test December 3, 2022 03:25 Inactive
@helayoty helayoty temporarily deployed to test December 5, 2022 20:48 Inactive
@helayoty helayoty temporarily deployed to test December 5, 2022 20:48 Inactive
@helayoty helayoty temporarily deployed to test December 8, 2022 20:48 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 01:44 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 01:44 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 03:09 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 03:09 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 03:11 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 03:11 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:04 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:05 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:06 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:13 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:13 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:24 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:24 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:47 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 04:47 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 21:15 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 21:16 — with GitHub Actions Inactive
@helayoty
Skip IPAddress check for windows containers
b5074a8 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test December 20, 2022 21:33 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test December 20, 2022 21:34 — with GitHub Actions Inactive
@Fei-Guo Fei-Guo merged commit 0c76852 into virtual-kubelet:master Dec 20, 2022
@helayoty helayoty deleted the windows-ip branch December 20, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I notice some confusion around the creation of Pods
2 participants
@helayoty @Fei-Guo