Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add unit test for auth and handle nil struct #348

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

helayoty
Copy link
Member

No description provided.

@helayoty helayoty temporarily deployed to test October 20, 2022 22:44 Inactive
@helayoty helayoty temporarily deployed to test October 20, 2022 22:44 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #348 (77f1231) into master (13ff7c6) will increase coverage by 1.22%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   42.22%   43.45%   +1.22%     
==========================================
  Files          45       45              
  Lines        5627     5627              
==========================================
+ Hits         2376     2445      +69     
+ Misses       3003     2919      -84     
- Partials      248      263      +15     
Impacted Files Coverage Δ
pkg/auth/auth.go 56.46% <20.00%> (+46.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test October 20, 2022 23:49 Inactive
@helayoty helayoty temporarily deployed to test October 20, 2022 23:49 Inactive
@helayoty helayoty changed the title fix: Auth fix fix: Add unit test for auth and handle nil struct Oct 20, 2022
@helayoty helayoty temporarily deployed to test October 21, 2022 00:09 Inactive
@helayoty helayoty temporarily deployed to test October 21, 2022 00:09 Inactive
@Fei-Guo Fei-Guo merged commit 83424f3 into virtual-kubelet:master Oct 21, 2022
@helayoty helayoty deleted the auth-fix branch October 21, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants