Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate metrics #315

Merged
merged 1 commit into from
Oct 7, 2022
Merged

refactor: Migrate metrics #315

merged 1 commit into from
Oct 7, 2022

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Oct 4, 2022 •
edited
Loading

  • The old code can be found here.
  • Add metrics_client.go to call the unsupported API /providers/microsoft.Insights/metrics
  • Remove types.go and move metrics structs to metrics_client.go

@helayoty helayoty temporarily deployed to test October 4, 2022 19:51 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 19:51 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 20:44 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 20:44 Inactive
@helayoty helayoty mentioned this pull request Oct 4, 2022
Closed
11 tasks
@helayoty helayoty temporarily deployed to test October 4, 2022 23:10 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 23:10 Inactive
@helayoty helayoty temporarily deployed to test October 5, 2022 03:14 Inactive
@helayoty helayoty temporarily deployed to test October 5, 2022 03:14 Inactive
@helayoty helayoty temporarily deployed to test October 5, 2022 03:47 Inactive
@helayoty helayoty temporarily deployed to test October 5, 2022 03:47 Inactive
@helayoty helayoty temporarily deployed to test October 7, 2022 02:28 Inactive
@helayoty helayoty temporarily deployed to test October 7, 2022 02:28 Inactive
@helayoty helayoty temporarily deployed to test October 7, 2022 02:29 Inactive
@helayoty helayoty temporarily deployed to test October 7, 2022 02:30 Inactive
@helayoty helayoty requested a review from Fei-Guo October 7, 2022 02:33
@helayoty helayoty marked this pull request as ready for review October 7, 2022 02:38
@helayoty helayoty temporarily deployed to test October 7, 2022 02:39 Inactive
@helayoty helayoty temporarily deployed to test October 7, 2022 02:39 Inactive
@Fei-Guo Fei-Guo merged commit 8f3fb29 into virtual-kubelet:master Oct 7, 2022
@helayoty helayoty changed the title chore: Migrate metrics refactor: Migrate metrics Oct 18, 2022
@helayoty helayoty deleted the migrate-metrics branch November 10, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helayoty @Fei-Guo