Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: Fixing project structure #18

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

larrydewey
Copy link
Contributor

Re-aligning the project to be more organized like snpguest.

Re-aligning the project to be more organized like snpguest.

Signed-off-by: Larry Dewey <larry.dewey@amd.com>
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the way it is, I only had a couple of comments, but neither is a deal breaker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be fixed in this PR, but verify is still PEM only. Also each cert has to be provided individually, do we want to just point to a directory that has all the certs?

@@ -71,140 +76,6 @@ fn cert_entries() -> Result<Vec<CertTableEntry>> {
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this functions in main.rs? Or maybe create and IOCTL.rs? Not necessary, just a suggestion.

@larrydewey larrydewey merged commit 61d191e into virtee:main Oct 24, 2023
@larrydewey larrydewey deleted the modularizing branch October 24, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants