-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certs: Adding CA and CRL functionality #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `snphost` was missing functionality to pull certificate chains and certificate revocation lists from the KDS. This adds that functionality to bring `snphost` into parody with other tools. Signed-off-by: Larry Dewey <larry.dewey@amd.com>
fd67979
to
bafe577
Compare
Updating the documentation to match the changes which were introduced. Signed-off-by: Larry Dewey <larry.dewey@amd.com>
7dcaead
to
60f1099
Compare
tylerfanelli
previously approved these changes
Sep 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only left one small note.
Adding in directory creation when the path does not previously exist. Signed-off-by: Larry Dewey <larry.dewey@amd.com>
60f1099
to
ecadfd1
Compare
DGonzalezVillal
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the |
tylerfanelli
previously approved these changes
Sep 18, 2023
Co-authored-by: Tyler Fanelli <tfanelli@redhat.com> Signed-off-by: Larry Dewey <larry.dewey@amd.com>
tylerfanelli
approved these changes
Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
snphost
was missing functionality to pull certificate chains and certificate revocation lists from the KDS. This adds that functionality to bringsnphost
into parody with other tools.