Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs: Adding CA and CRL functionality #15

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

larrydewey
Copy link
Contributor

Previously, snphost was missing functionality to pull certificate chains and certificate revocation lists from the KDS. This adds that functionality to bring snphost into parody with other tools.

@larrydewey larrydewey added the enhancement New feature or request label Sep 14, 2023
@larrydewey larrydewey self-assigned this Sep 14, 2023
@auto-assign auto-assign bot requested a review from ryansavino September 14, 2023 17:55
Previously, `snphost` was missing functionality
to pull certificate chains and certificate
revocation lists from the KDS. This adds that
functionality to bring `snphost` into parody with
other tools.

Signed-off-by: Larry Dewey <larry.dewey@amd.com>
@larrydewey larrydewey changed the title certs: Adding CA and CRL functionality WIP: certs: Adding CA and CRL functionality Sep 14, 2023
@larrydewey larrydewey changed the title WIP: certs: Adding CA and CRL functionality WIP certs: Adding CA and CRL functionality Sep 14, 2023
Updating the documentation to match the changes which were introduced.

Signed-off-by: Larry Dewey <larry.dewey@amd.com>
@larrydewey larrydewey changed the title WIP certs: Adding CA and CRL functionality certs: Adding CA and CRL functionality Sep 14, 2023
@larrydewey larrydewey force-pushed the certchain branch 3 times, most recently from 7dcaead to 60f1099 Compare September 15, 2023 17:08
tylerfanelli
tylerfanelli previously approved these changes Sep 16, 2023
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only left one small note.

Adding in directory creation when the path does not previously exist.

Signed-off-by: Larry Dewey <larry.dewey@amd.com>
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerfanelli
Copy link
Member

the PR-fixes commit can be squashed into the first commit.

tylerfanelli
tylerfanelli previously approved these changes Sep 18, 2023
Co-authored-by: Tyler Fanelli <tfanelli@redhat.com>
Signed-off-by: Larry Dewey <larry.dewey@amd.com>
@tylerfanelli tylerfanelli merged commit 9eded4e into virtee:main Sep 18, 2023
@larrydewey larrydewey deleted the certchain branch September 19, 2023 01:32
@larrydewey larrydewey mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants