Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heater freeze on power loss/reset #353

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix heater freeze on power loss/reset #353

merged 1 commit into from
Jan 18, 2022

Conversation

vintagepc
Copy link
Owner

Description

Fix bug with MK3 heater getting stuck during UVLO or other reset

Behaviour/ Breaking changes

None - should fix broken behaviour, only adds code.

Have you tested the changes?

Resolves the issue on my end.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #353 (fa39292) into master (f2a5895) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         167      167           
  Lines        7768     7772    +4     
=======================================
+ Hits         7100     7104    +4     
  Misses        668      668           
Impacted Files Coverage Δ
parts/components/Heater.h 100.00% <ø> (ø)
parts/boards/EinsyRambo.cpp 96.57% <100.00%> (+0.02%) ⬆️
parts/components/Heater.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a5895...fa39292. Read the comment docs.

@vintagepc vintagepc merged commit 8d86fc8 into master Jan 18, 2022
@vintagepc vintagepc deleted the heater-reset-bug branch January 18, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant