Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal/screenshot related bugs #336

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Fix terminal/screenshot related bugs #336

merged 2 commits into from
Oct 28, 2021

Conversation

vintagepc
Copy link
Owner

Description

Fixes some GL related bugs with the terminal and screenshot scaling.

Behaviour/ Breaking changes

Terminal no longer vanishes when scaling
Screenshots created using the hotkey now respect the actual scaled window size.

Linked issues:

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #336 (016769d) into master (029cc59) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   90.95%   90.92%   -0.03%     
==========================================
  Files         162      162              
  Lines        7515     7517       +2     
==========================================
  Hits         6835     6835              
- Misses        680      682       +2     
Impacted Files Coverage Δ
MK404.cpp 86.32% <0.00%> (ø)
parts/components/GLHelper.cpp 83.49% <33.33%> (-1.51%) ⬇️
parts/printers/Prusa_MMU2.cpp 88.88% <100.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029cc59...016769d. Read the comment docs.

@vintagepc vintagepc merged commit 43df58c into master Oct 28, 2021
@vintagepc vintagepc deleted the misc-bugfixes-GL branch October 28, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Screenshot should scale. [BUG] Terminal is glitched on standalone MMU2 and when resizing.
1 participant