Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #325

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Misc fixes #325

merged 3 commits into from
Aug 21, 2021

Conversation

vintagepc
Copy link
Owner

@vintagepc vintagepc commented Aug 21, 2021

Description

Minor features and fixes - a ? hotkey and a null pointer dereference.

Behaviour/ Breaking changes

  • Prints key reference to console if user presses ? key
  • Sim no longer crashes if holding C and trhe card unmounts while mid-read.

Linked issues:

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #325 (b282546) into master (03b0780) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files         148      148           
  Lines        6707     6708    +1     
=======================================
+ Hits         5959     5960    +1     
  Misses        748      748           
Impacted Files Coverage Δ
parts/KeyController.cpp 100.00% <100.00%> (ø)
parts/components/SDCard.cpp 93.55% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b0780...b282546. Read the comment docs.

@vintagepc vintagepc merged commit a3a61b1 into master Aug 21, 2021
@vintagepc vintagepc deleted the Misc-fixes branch August 21, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant