Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#315 - WaitForReset() #316

Merged
merged 2 commits into from
Jun 27, 2021
Merged

#315 - WaitForReset() #316

merged 2 commits into from
Jun 27, 2021

Conversation

vintagepc
Copy link
Owner

Description

Adds ability to wait for board reset in a script.

Behaviour/ Breaking changes

None - adds new capability

Have you tested the changes?

Not yet.

Linked issues:

@vintagepc vintagepc added the enhancement New feature or request label Jun 24, 2021
@vintagepc vintagepc requested a review from wavexx June 24, 2021 12:28
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #316 (c6e0aec) into master (bb0a4e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.01%     
==========================================
  Files         140      140              
  Lines        6671     6681      +10     
==========================================
+ Hits         5935     5945      +10     
  Misses        736      736              
Impacted Files Coverage Δ
parts/Board.h 91.66% <ø> (ø)
parts/Board.cpp 76.12% <100.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a4e2...c6e0aec. Read the comment docs.

@wavexx
Copy link
Collaborator

wavexx commented Jun 27, 2021

Just tested the behavior, it's working as intended.

@vintagepc
Copy link
Owner Author

Awesome, I'll see if I can sneak in an automated test for it somewhere and then merge it in!

@vintagepc vintagepc merged commit 86699d2 into master Jun 27, 2021
@vintagepc vintagepc deleted the 315-state-reset-wait branch June 27, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] ScriptHost: Board::WaitForReset()
2 participants