Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with deltaT and the first tick of a print #278

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

vintagepc
Copy link
Owner

Description

Fixes a crash if the first E tick of a 3d print happens after the cycle count is > UINT32_MAX

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #278 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.02%     
==========================================
  Files         138      138              
  Lines        6358     6360       +2     
==========================================
+ Hits         5631     5632       +1     
- Misses        727      728       +1     
Impacted Files Coverage Δ
utility/MK3SGL.cpp 89.14% <50.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfd173...44819bd. Read the comment docs.

@vintagepc vintagepc merged commit 208ef25 into master Oct 24, 2020
@vintagepc vintagepc deleted the deltaT-crash-fix branch October 24, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants