Patch A4982 step-position conversion functions #267
Conversation
|
Thanks. I'll review this after work. Fix seems a little counter-intuitive given how the variable step resolution is handled, but if it works, it works and I'll update the automated tests accordingly. |
|
The uiStepsPerMM configuration option already represents x16 microsteps. On the TMC2130 (Einsy board) this value is *16 in the configuration file. So you handled an issue that didn't exist and ended up creating another. |
|
Ah, something I did for the TMCs crept in to the miniRambo and I didn't finish the implementation. That would definitely do it. I was thinking the steps per mm was still the direct firmware value and not corrected for this. The test will likely just need some adjusting in the script - it was doing some assorted step counting to ensure that we were hitting the correct number of steps before hitting the endstops in various configurations. I suspect the number of steps counted by the micro might have changed as a result of this. Don't feel obligated to dive too much into that but test can be run standalone with |
|
strange, not sure why the PR isn't picking up my commit that should fix the tests. |
Automated Test Code Coverage ReportView details...
TOTAL: 6417 lines of code, 5785 lines executed, 90% covered. |
Description
Fixes steps/mm being calculated incorrectly on miniRambo based boards.
Behaviour/ Breaking changes
None
Have you tested the changes?
Tested Prusa_MK2_mR13 variant with two different microstepping configurations. Both worked as expected.
Linked issues:
closes #253