Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Key handler registration #238

Closed
vintagepc opened this issue Sep 16, 2020 · 0 comments · Fixed by #241
Closed

[IMPROVEMENT] Key handler registration #238

vintagepc opened this issue Sep 16, 2020 · 0 comments · Fixed by #241
Assignees
@vintagepc
Labels
enhancement New feature or request
Milestone
v1.1

Comments

@vintagepc
Copy link
Owner

Is your feature request related to a problem? Please describe.
Allow components to register a key handler with the board or printer. This will eliminate a lot of copy-paste code and branching due to e.g. toggling fsensors - each printer will automatically get the key interactions from the components it has, much like the way the context menu works.

Additional notes:
Add doc generation for the printers so that we can autogen the available keys for each printer.
@vintagepc vintagepc added the enhancement New feature or request label Sep 16, 2020
@vintagepc vintagepc added this to the v1.1 milestone Sep 16, 2020
@vintagepc vintagepc self-assigned this Sep 17, 2020
vintagepc added a commit that referenced this issue Sep 19, 2020
@vintagepc
#238-key-improvements
64c42b4
@vintagepc vintagepc mentioned this issue Sep 19, 2020
Merged
vintagepc added a commit that referenced this issue Sep 19, 2020
@vintagepc
#238 keyboard control improvement (#241)
ab781c7 
* #238-key-improvements
* rework tests, cleanup, improve handling
* Improve doc generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vintagepc vintagepc

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

#238 keyboard control improvement vintagepc/MK404
1 participant
@vintagepc