Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item_wrap for str and int #94

Merged
merged 4 commits into from
Dec 18, 2021
Merged

item_wrap for str and int #94

merged 4 commits into from
Dec 18, 2021

Conversation

jgroom33
Copy link
Contributor

resolve #93

@vinitkumar
Copy link
Owner

Thanks for your contribution, and apologies for a bit of late response, I have been swamped at work.

I will review the code and if all goes fine, I will merge it.

@vinitkumar
Copy link
Owner

@jgroom33 Can you please also update the readme with an example of the above change, this might help people who are looking for similar functionality with this library.

- add tests
- refactor
@jgroom33
Copy link
Contributor Author

I refactored a bit and added a couple new tests too

@vinitkumar
Copy link
Owner

I refactored a bit and added a couple new tests too

Thanks, this looks great. I had a question though, it this email correct? <mail@jgroom33@outlook.com> It contains 2 @ in it. If not, please update it and this looks good to be merged.

@jgroom33
Copy link
Contributor Author

fixed

@vinitkumar
Copy link
Owner

Awesome. Thank you :) I will be merging it now and hopefully release a new build to PYPI as well.

@vinitkumar vinitkumar merged commit 3e57347 into vinitkumar:master Dec 18, 2021
@vinitkumar
Copy link
Owner

@jgroom33 It is now released on the PyPI: https://pypi.org/project/json2xml/3.9.0/

Congrats on your first contributions and release for PYPI.

I hope you contribute more to this project 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

item_wrap for str and int
2 participants