Fix warning test #113
Merged
Fix warning test #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed all warnings of the running test.
For some test the result was stored in a variable. While I understand this can be handy to debug, I still removed those variables so you don't have to think about every warning if it can be ignored or not. A little bit piece of mind 😌
Other where long lines of code, please check if it is your style of multiline code or want to structure it a different way.
Included a dev requirement file which can be extended so a future contributor only has to install that one to test the package, as it installs the normal requirements as well.
Thanks for creating the package!