Do not require nor ship pytest and dependancies with json2xml #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psi29a
changed the title
|
@psi29a You are outstanding. Thanks for this contribution, busy at work now, but expect a bugfix release tonight. Will comment on this thread when I do it. |
|
@vinitkumar brilliant, thank you! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #103
This puts testing related requirements into
test_requirementsin setup.py; this frees up requirements.in to only be libs needed for json2xml to run.Running
python setup.py teststill works.Also fixed tox, it now runs correctly. It is trying to run setup.py which requires requirements.txt which wasn't in the MANIFEST.in file. Should be good to go!
Please issue a bug fix release. :)
This should now unblock others from using json2xml who have strict split in deployment and testing.