Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): discrete schema, jvm mode in dev (#23) #26

Merged
merged 1 commit into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/release-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ env:
SERVICE: fpi-load-api-dev
REGION: asia-east1
SONAR_PROJECT_KEY: vincejv_fpi-load-api
NATIVE_IMAGE_BUILDER: quay.io/quarkus/ubi-quarkus-mandrel:22.2-java17
SERVICE_CPU: 1000m
SERVICE_MEMORY: 384Mi
SERVICE_MEMORY: 768Mi
SERVICE_ENV: dev

jobs:
Expand Down Expand Up @@ -62,7 +61,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
run: mvn -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=${{ env.SONAR_PROJECT_KEY }} -Dsonar.qualitygate.wait=true
run: mvn -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=${{ env.SONAR_PROJECT_KEY }} -Dsonar.qualitygate.wait=true -P allow-snapshots

deploy_to_cloud:
name: Deploy to Cloud Run
Expand Down Expand Up @@ -102,8 +101,8 @@ jobs:
run: |
echo "service_image_path=${{ env.REGISTRY }}/${{ env.PROJECT_ID }}/${{ env.GHUB_REPO_NAME }}/${{ env.SERVICE }}:${{ steps.gen_ver.outputs.artifact_version }}" >> $GITHUB_OUTPUT

- name: Generate native image
run: mvn -B package -Pnative -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=${{ env.NATIVE_IMAGE_BUILDER }}
- name: Create JVM package
run: mvn -B package -P allow-snapshots

- name: Google Auth
id: gcp-auth
Expand Down Expand Up @@ -141,6 +140,7 @@ jobs:
uses: docker/build-push-action@v3
with:
context: .
file: Dockerfile.dev
push: true
tags: | # ${{ steps.meta.outputs.tags }} - (For public repositories like docker hub)
${{ steps.image_version.outputs.service_image_path }}
Expand All @@ -154,8 +154,9 @@ jobs:
region: ${{ env.REGION }}
image: ${{ steps.image_version.outputs.service_image_path }}
project_id: ${{ env.PROJECT_ID }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }} --timeout 900 --no-cpu-throttling
env_vars: |
DB_NAME=load-api-dev
OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
Expand All @@ -166,6 +167,7 @@ jobs:
LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
USER_BASE_URI=${{ secrets.USER_BASE_URI }}
secrets: |
MONGO_CONN_STRING=vbl_mongo_connection_string:latest
OIDC_SECRET=oidc_secret_keycloak:latest
Expand Down Expand Up @@ -216,7 +218,7 @@ jobs:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
run: mvn -B deploy -Prelease-for-oss
run: mvn -B deploy -P release-for-oss,allow-snapshots

pr_update:
name: Pull request update
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,9 @@ jobs:
region: ${{ env.REGION }}
image: ${{ needs.versioning.outputs.service_image_path }}
project_id: ${{ env.PROJECT_ID }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }} --cpu-throttling
env_vars: |
DB_NAME=load-api-prod
OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
Expand All @@ -208,6 +209,7 @@ jobs:
LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
USER_BASE_URI=${{ secrets.USER_BASE_URI }}
secrets: |
MONGO_CONN_STRING=vbl_mongo_connection_string:latest
OIDC_SECRET=oidc_secret_keycloak:latest
Expand Down
91 changes: 91 additions & 0 deletions Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
####
# This Dockerfile is used in order to build a container that runs the Quarkus application in JVM mode
#
# Before building the container image run:
#
# ./mvnw package
#
# Then, build the image with:
#
# docker build -f src/main/docker/Dockerfile.jvm -t quarkus/code-with-quarkus-jvm .
#
# Then run the container using:
#
# docker run -i --rm -p 8080:8080 quarkus/code-with-quarkus-jvm
#
# If you want to include the debug port into your docker image
# you will have to expose the debug port (default 5005) like this : EXPOSE 8080 5005
#
# Then run the container using :
#
# docker run -i --rm -p 8080:8080 quarkus/code-with-quarkus-jvm
#
# This image uses the `run-java.sh` script to run the application.
# This scripts computes the command line to execute your Java application, and
# includes memory/GC tuning.
# You can configure the behavior using the following environment properties:
# - JAVA_OPTS: JVM options passed to the `java` command (example: "-verbose:class")
# - JAVA_OPTS_APPEND: User specified Java options to be appended to generated options
# in JAVA_OPTS (example: "-Dsome.property=foo")
# - JAVA_MAX_MEM_RATIO: Is used when no `-Xmx` option is given in JAVA_OPTS. This is
# used to calculate a default maximal heap memory based on a containers restriction.
# If used in a container without any memory constraints for the container then this
# option has no effect. If there is a memory constraint then `-Xmx` is set to a ratio
# of the container available memory as set here. The default is `50` which means 50%
# of the available memory is used as an upper boundary. You can skip this mechanism by
# setting this value to `0` in which case no `-Xmx` option is added.
# - JAVA_INITIAL_MEM_RATIO: Is used when no `-Xms` option is given in JAVA_OPTS. This
# is used to calculate a default initial heap memory based on the maximum heap memory.
# If used in a container without any memory constraints for the container then this
# option has no effect. If there is a memory constraint then `-Xms` is set to a ratio
# of the `-Xmx` memory as set here. The default is `25` which means 25% of the `-Xmx`
# is used as the initial heap size. You can skip this mechanism by setting this value
# to `0` in which case no `-Xms` option is added (example: "25")
# - JAVA_MAX_INITIAL_MEM: Is used when no `-Xms` option is given in JAVA_OPTS.
# This is used to calculate the maximum value of the initial heap memory. If used in
# a container without any memory constraints for the container then this option has
# no effect. If there is a memory constraint then `-Xms` is limited to the value set
# here. The default is 4096MB which means the calculated value of `-Xms` never will
# be greater than 4096MB. The value of this variable is expressed in MB (example: "4096")
# - JAVA_DIAGNOSTICS: Set this to get some diagnostics information to standard output
# when things are happening. This option, if set to true, will set
# `-XX:+UnlockDiagnosticVMOptions`. Disabled by default (example: "true").
# - JAVA_DEBUG: If set remote debugging will be switched on. Disabled by default (example:
# true").
# - JAVA_DEBUG_PORT: Port used for remote debugging. Defaults to 5005 (example: "8787").
# - CONTAINER_CORE_LIMIT: A calculated core limit as described in
# https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt. (example: "2")
# - CONTAINER_MAX_MEMORY: Memory limit given to the container (example: "1024").
# - GC_MIN_HEAP_FREE_RATIO: Minimum percentage of heap free after GC to avoid expansion.
# (example: "20")
# - GC_MAX_HEAP_FREE_RATIO: Maximum percentage of heap free after GC to avoid shrinking.
# (example: "40")
# - GC_TIME_RATIO: Specifies the ratio of the time spent outside the garbage collection.
# (example: "4")
# - GC_ADAPTIVE_SIZE_POLICY_WEIGHT: The weighting given to the current GC time versus
# previous GC times. (example: "90")
# - GC_METASPACE_SIZE: The initial metaspace size. (example: "20")
# - GC_MAX_METASPACE_SIZE: The maximum metaspace size. (example: "100")
# - GC_CONTAINER_OPTIONS: Specify Java GC to use. The value of this variable should
# contain the necessary JRE command-line options to specify the required GC, which
# will override the default of `-XX:+UseParallelGC` (example: -XX:+UseG1GC).
# - HTTPS_PROXY: The location of the https proxy. (example: "myuser@127.0.0.1:8080")
# - HTTP_PROXY: The location of the http proxy. (example: "myuser@127.0.0.1:8080")
# - NO_PROXY: A comma separated lists of hosts, IP addresses or domains that can be
# accessed directly. (example: "foo.example.com,bar.example.com")
#
###
FROM registry.access.redhat.com/ubi8/openjdk-17-runtime:1.14

ENV LANGUAGE='en_US:en'

# We make four distinct layers so if there are application changes the library layers can be re-used
COPY --chown=185 *core/target/quarkus-app/lib/ /deployments/lib/
COPY --chown=185 *core/target/quarkus-app/*.jar /deployments/
COPY --chown=185 *core/target/quarkus-app/app/ /deployments/app/
COPY --chown=185 *core/target/quarkus-app/quarkus/ /deployments/quarkus/

EXPOSE 8080
USER 185
ENV JAVA_OPTS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager"
ENV JAVA_APP_JAR="/deployments/quarkus-run.jar"
7 changes: 6 additions & 1 deletion fpi-load-api-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@

<dependencies>

<dependency>
<groupId>com.abavilla</groupId>
<artifactId>fpi-load-api-lib</artifactId>
</dependency>

<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-rest-client-reactive-jackson</artifactId>
Expand Down Expand Up @@ -92,7 +97,7 @@

<dependency>
<groupId>com.abavilla</groupId>
<artifactId>fpi-load-api-lib</artifactId>
<artifactId>fpi-sms-api-lib</artifactId>
</dependency>

</dependencies>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@

import com.abavilla.fpi.fw.config.codec.IEnumCodecProvider;
import com.abavilla.fpi.load.entity.enums.SkuType;
import com.abavilla.fpi.load.entity.enums.Telco;
import com.abavilla.fpi.load.ext.entity.enums.ApiStatus;
import com.abavilla.fpi.telco.ext.codec.ApiStatusCodec;
import com.abavilla.fpi.telco.ext.codec.TelcoCodec;
import com.abavilla.fpi.telco.ext.entity.enums.ApiStatus;
import com.abavilla.fpi.telco.ext.entity.enums.Telco;
import org.bson.codecs.Codec;

/**
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading