feat: add zellij support #61
Conversation
There was a problem hiding this comment.
Hey, thanks for taking a look at this, support for zellij is indeed something that is very much wanted.
I wrote a couple of pointers and generally I have the feeling that this probably doesn't need as many code changes, the framework is pretty much already there to accomplish this with just the configuration (see also :h tpipeline-external).
| if !empty($TMUX) | ||
| let g:tpipeline_size = str2nr(systemlist("sh -c 'echo \"\"; tmux display-message -p \"#{window_width}\"'")[-1]) | ||
| elseif !empty($ZELLIJ) | ||
| " TODO: verify if this is reasonable. |
There was a problem hiding this comment.
That's not the correct size as soon as there is a vertical split in zellij. This can also be done by just setting the TpipelineSize autocommand callback, so no code changes needed here.
There was a problem hiding this comment.
I tried without, then the STL would be rendered without markers - meaning that the whole line would be rendered on the left side. Currently, zellij has no API to get the width. We probably have to wait.
There was a problem hiding this comment.
And also: I don't fully understand the case you tried to describe. In my setup, the bar always takes the full width of the terminal. When I do a split, my editor's width halves but the bar stays in full width and so can the STL.
There was a problem hiding this comment.
tput cols will evaluate to the split's width, not to the full width. You likely didn't notice a difference, because half the width was still enough width.
Try resizing the terminal so that it's width is barely enough to fit the vim statusline. Then split the terminal, and you should notice that the statusline is truncated to half the terminal's width.
autoload/tpipeline.vim
Outdated
| let p = "/tmp/tmux-" . systemlist("id -u")[-1] | ||
|
|
||
| if !empty($ZELLIJ) | ||
| " e.g. /tmp/zjstatus-$UID/$SESSION_NAME-$PANE_ID-vimbridge |
There was a problem hiding this comment.
Hmm I'd probably prefer to just use a generic naming scheme, so that the same code path can be used for tmux and zellij.
There was a problem hiding this comment.
Something like /tmp/vim-$UID/$SESSION_ID-bridge.
I am curious what you need $PANE_ID for? There is always at most one vim pane focused, which will be rendering the active statusline, no need to support multiple panes at the same time.
In any case this requires some careful planning to not break the config for existing users too much.
plugin/tpipeline.vim
Outdated
| @@ -1,4 +1,4 @@ | |||
| if exists('g:loaded_tpipeline') || (empty($TMUX) && !exists("g:tpipeline_refreshcmd")) || !(has('nvim-0.6') ? len(nvim_list_uis()) : (has('job') && has('patch-8.2.4650'))) || has('gui_running') | |||
| if exists('g:loaded_tpipeline') || (empty($ZELLIJ) && empty($TMUX) && !exists("g:tpipeline_refreshcmd")) || !(has('nvim-0.6') ? len(nvim_list_uis()) : (has('job') && has('patch-8.2.4650'))) || has('gui_running') | |||
There was a problem hiding this comment.
This is probably also not needed, if instead g:tpipeline_refreshcmd is set to something suitable for zellij (i.e. perhaps manually trigger an update of the statusline, similar to tmux refresh-client -S).
There was a problem hiding this comment.
Yeah, for sure. However that is not possible as of now. We have to wait for pipes in zellij zellij-org/zellij#3066. It is already merged but not released yet. So currently we have no way to manually trigger an update - my config updates the bar every second.
There was a problem hiding this comment.
OK let's wait for zellij's next release then.
There was a problem hiding this comment.
Looks like it's possible to trigger updates from external now: https://zellij.dev/news/welcome-screen-pipes-filepicker/#pipes
E.g.: zpipe my-plugin hi!
So with dj95/zjstatus#46 it should be pretty easy now to get this working with zellij, probably doesn't need many code changes.
There was a problem hiding this comment.
true, I will look into it as soon as time allows me to :)
Very rudimentary, draft to support zellij.
Very rudimentary draft to support zellij. I primarily wish to get some feedback on what you think is missing.
Depends on: zellij-org/zellij#2835