Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_encode() returns a non-empty-string with JSON_THROW_ON_ERROR | JSON_UNESCAPED_UNICODE #9479

Merged
merged 2 commits into from
Mar 12, 2023
Merged

json_encode() returns a non-empty-string with JSON_THROW_ON_ERROR | JSON_UNESCAPED_UNICODE #9479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2abefb9
Return a non-empty-string with JSON_THROW_ON_ERROR | JSON_UNESCAPED_U…
fluffycondor Mar 10, 2023
7ba0f97
Fix test
fluffycondor Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stubs/CoreGenericFunctions.phpstub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,11 @@ function json_decode(string $json, ?bool $associative = null, int $depth = 512,
/**
* @psalm-pure
*
* @return ($flags is 4194304 ? non-empty-string : non-empty-string|false)
* @return (
* $flags is 4194304
* ? non-empty-string
* : ($flags is 4194560 ? non-empty-string : non-empty-string|false)
* )
*
* @psalm-flow ($value) -> return
* @psalm-ignore-falsable-return
Expand Down
8 changes: 8 additions & 0 deletions tests/CoreStubsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,13 @@ function foo(string $foo): string
'$a===' => 'string',
],
];
yield 'json_encode returns a non-empty-string provided JSON_THROW_ON_ERROR | JSON_UNESCAPED_UNICODE' => [
'code' => '<?php
$a = json_encode([], JSON_UNESCAPED_UNICODE | JSON_THROW_ON_ERROR);
',
'assertions' => [
'$a===' => 'non-empty-string',
],
];
}
}