Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip a test because we removed the feature for now #7642

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Feb 11, 2022

Not sure why this test doesn't explode on 4.x but we removed this feature for now due to shenanigans with stubs from plugins and this makes master branch fail

@weirdan
Copy link
Collaborator

weirdan commented Feb 11, 2022

why this test doesn't explode on 4.x

Because it's absent from that branch 🤷‍♂️

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 11, 2022
@orklah orklah merged commit 29b856e into vimeo:master Feb 11, 2022
@AndrolGenhald
Copy link
Collaborator

I did a bit of work to allow mixed in stubs for PHP 7.4 on #7641, this test is still failing there though, I didn't look into it much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants