Prevent dupe records

vimeo · Oct 19, 2020 · db119d6 · db119d6
1 parent f9deaca
commit db119d6
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/Psalm/Type/Reconciler.php b/src/Psalm/Type/Reconciler.php
@@ -807,8 +807,6 @@ protected static function triggerIssueForImpossible(
     ): void {
         $not = $assertion[0] === '!';
 
-        $safe_assertion = $assertion;
-
         if ($not) {
             $assertion = substr($assertion, 1);
         }
@@ -832,7 +830,7 @@ protected static function triggerIssueForImpossible(
                             . ' for ' . $key
                             . ' is ' . ($not ? 'never ' : 'always ') . $assertion,
                         $code_location,
-                        $old_var_type_string . ' ' . $safe_assertion
+                        $old_var_type_string . ' ' . $assertion
                     ),
                     $suppressed_issues
                 )) {
@@ -845,7 +843,7 @@ protected static function triggerIssueForImpossible(
                             . ' for ' . $key
                             . ' is ' . ($not ? 'never ' : 'always ') . $assertion,
                         $code_location,
-                        $old_var_type_string . ' ' . $safe_assertion
+                        $old_var_type_string . ' ' . $assertion
                     ),
                     $suppressed_issues
                 )) {
@@ -860,7 +858,7 @@ protected static function triggerIssueForImpossible(
                             . ' for ' . $key
                             . ' is ' . ($not ? 'always ' : 'never ') . $assertion,
                         $code_location,
-                        $old_var_type_string . ' ' . $safe_assertion
+                        $old_var_type_string . ' ' . $assertion
                     ),
                     $suppressed_issues
                 )) {
@@ -873,15 +871,15 @@ protected static function triggerIssueForImpossible(
                             . ' for ' . $key
                             . ' is never ' . $assertion,
                         $code_location,
-                        $old_var_type_string . ' ' . $safe_assertion
+                        $old_var_type_string . ' ' . $assertion
                     );
                 } else {
                     $issue = new TypeDoesNotContainType(
                         'Type ' . $old_var_type_string
                             . ' for ' . $key
                             . ' is ' . ($not ? 'always ' : 'never ') . $assertion,
                         $code_location,
-                        $old_var_type_string . ' ' . $safe_assertion
+                        $old_var_type_string . ' ' . $assertion
                     );
                 }