Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set refundId #5

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Set refundId #5

merged 4 commits into from
Jul 13, 2021

Conversation

jcmanzo
Copy link
Contributor

@jcmanzo jcmanzo commented Jul 2, 2021

Sets the refundId property when constructing refund from gateway reponse. In other gateways this value would contain the merchant-specified refund id but BlueSnap does not support this. This PR makes sure that getRefundId will return a non-nullable value.

@jcmanzo jcmanzo self-assigned this Jul 2, 2021
@jcmanzo
Copy link
Contributor Author

jcmanzo commented Jul 12, 2021

There is a single test that does not pass due to a couple issues I've discovered but feel don't need to be addressed at this point.

  • Phpunit fails due to this error https://www.php.net/manual/en/reflectiontype.tostring.php
  • The issue shows up because this repo is using an older version of phpunit (4.8.36) due to "needing" to support older php versions.
  • The issue is a warning in pre 7.x.x versions but in more recent version starting with 7, this now results in a fatal failure.

We should ideally upgrade this whole library to use the latest php version to avoid these types of problems but that's a larger undertaking and not in scope of what this PR is hoping to achieve.

src/Message/Refund.php Outdated Show resolved Hide resolved
@jcmanzo jcmanzo merged commit 2123e29 into master Jul 13, 2021
@jcmanzo jcmanzo deleted the standardize-refund-id-retrieval branch July 13, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants