-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tex should not take '.out' ext #14670
Conversation
// '.out' should be a very common ext, // i think and supposed 'tex' should not or was not taking it as belonging to it. Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
If it's such a common extension, why hasn't it been recognized then? If not TeX, what should these files be? Please motivate your change by an actual problem instead of "previous change bad! revert!" |
If it's such a common extension, why hasn't it been recognized then? If not TeX, what _should_ these files be? Please motivate your change by an actual problem instead of "previous change bad! revert!"
interesting logic or mindset, have you ever do `gcc foo.c` before?
…--
shane.xb.qian
|
It's a very generic extension often used to indicate the file is the output of some generation/compilation tool. It hasn't been assigned a file type until recently, I assume, because it could be anything. We should, ideally, attempt to provide some content sanity check. |
Yes, and have you ever done |
please find someone else to argue, and this is just a correction for official vim, you can do whatever you like. |
We all want Vim's filetype detection to be as complete and correct as possible. Asking for motivation of changes so their effect can be gauged against the intent is part of that. (And, as a personal observation, your transparent attempts at gatekeeping "official vim" by adding friction to other contributors are getting hard to take. I wish you could be more constructive in your comments.) Again, is there a better filetype for |
i donot think so, i weclome every nice and wonderful contribution to official vim and the past decision which Bram did. |
Yeah, using I have used out files as a generic text file in the past, but that may as well be wrong for other users. |
Problem: filetype: .out files recognized as tex files Solution: Do not set an explicit filetype until it is clear what this should be (shane.xb.qian) closes: vim/vim#14670 vim/vim@e35478b Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
Problem: filetype: .out files recognized as tex files Solution: Do not set an explicit filetype until it is clear what this should be (shane.xb.qian) closes: vim/vim#14670 vim/vim@e35478b Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
Problem: filetype: .out files recognized as tex files Solution: Do not set an explicit filetype until it is clear what this should be (shane.xb.qian) closes: vim/vim#14670 vim/vim@e35478b Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
Problem: filetype: .out files recognized as tex files Solution: Do not set an explicit filetype until it is clear what this should be (shane.xb.qian) closes: vim/vim#14670 vim/vim@e35478b Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
// '.out' should be a very common ext,
// i think and supposed 'tex' should not or was not taking it as belonging to it.
related: #14456