Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tex should not take '.out' ext #14670

Closed
wants to merge 1 commit into from

Conversation

Shane-XB-Qian
Copy link
Contributor

// '.out' should be a very common ext,
// i think and supposed 'tex' should not or was not taking it as belonging to it.

related: #14456

// '.out' should be a very common ext,
// i think and supposed 'tex' should not or was not taking it as belonging to it.

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@clason
Copy link
Contributor

clason commented Apr 30, 2024

If it's such a common extension, why hasn't it been recognized then? If not TeX, what should these files be? Please motivate your change by an actual problem instead of "previous change bad! revert!"

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 30, 2024 via email

@dkearns
Copy link
Contributor

dkearns commented Apr 30, 2024

It's a very generic extension often used to indicate the file is the output of some generation/compilation tool. It hasn't been assigned a file type until recently, I assume, because it could be anything.

We should, ideally, attempt to provide some content sanity check.

@clason
Copy link
Contributor

clason commented Apr 30, 2024

If it's such a common extension, why hasn't it been recognized then? If not TeX, what should these files be? Please motivate your change by an actual problem instead of "previous change bad! revert!"
interesting logic or mindset, have you ever do gcc foo.c before?

-- shane.xb.qian

Yes, and have you ever done vim a.out before? And has this regressed now? (I'm not saying these files should be recognized as TeX -- in fact, they're usually empty -- but you still should be able to give a better motivation than "I think this should not be done.")

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 30, 2024 via email

@Shane-XB-Qian
Copy link
Contributor Author

If it's such a common extension, why hasn't it been recognized then? If not TeX, what should these files be? Please motivate your change by an actual problem instead of "previous change bad! revert!"
interesting logic or mindset, have you ever do gcc foo.c before?

-- shane.xb.qian

Yes, and have you ever done vim a.out before? And has this regressed now? (I'm not saying these files should be recognized as TeX -- in fact, they're usually empty -- but you still should be able to give a better motivation than "I think this should not be done.")

please find someone else to argue, and this is just a correction for official vim, you can do whatever you like.

@clason
Copy link
Contributor

clason commented Apr 30, 2024

We all want Vim's filetype detection to be as complete and correct as possible. Asking for motivation of changes so their effect can be gauged against the intent is part of that. (And, as a personal observation, your transparent attempts at gatekeeping "official vim" by adding friction to other contributors are getting hard to take. I wish you could be more constructive in your comments.)

Again, is there a better filetype for .out files that can be recognized based on contents? Can't we do better than simply not recognizing them at all?

@Shane-XB-Qian
Copy link
Contributor Author

your transparent attempts at gatekeeping "official vim" by adding friction to other contributors are getting hard to take.

i donot think so, i weclome every nice and wonderful contribution to official vim and the past decision which Bram did.
and everyone is free and has right to talk,
just please donot throw your mood to me.

@chrisbra
Copy link
Member

Yeah, using .out for tex was probably an error. Let's not set a filetype for this one, since it can be anything and probably for some users it might be more typically filetype a while others may encounter it as totally different filetype.

I have used out files as a generic text file in the past, but that may as well be wrong for other users.

@chrisbra chrisbra closed this in e35478b Apr 30, 2024
@Shane-XB-Qian Shane-XB-Qian deleted the fix_tex_out_ext branch May 1, 2024 04:29
clason added a commit to clason/neovim that referenced this pull request May 1, 2024
Problem:  filetype: .out files recognized as tex files
Solution: Do not set an explicit filetype until it is clear what this
          should be (shane.xb.qian)

closes: vim/vim#14670

vim/vim@e35478b

Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
clason added a commit to neovim/neovim that referenced this pull request May 1, 2024
Problem:  filetype: .out files recognized as tex files
Solution: Do not set an explicit filetype until it is clear what this
          should be (shane.xb.qian)

closes: vim/vim#14670

vim/vim@e35478b

Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
phanen pushed a commit to phanen/neovim that referenced this pull request May 3, 2024
Problem:  filetype: .out files recognized as tex files
Solution: Do not set an explicit filetype until it is clear what this
          should be (shane.xb.qian)

closes: vim/vim#14670

vim/vim@e35478b

Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
huangyingw pushed a commit to huangyingw/neovim that referenced this pull request May 31, 2024
Problem:  filetype: .out files recognized as tex files
Solution: Do not set an explicit filetype until it is clear what this
          should be (shane.xb.qian)

closes: vim/vim#14670

vim/vim@e35478b

Co-authored-by: shane.xb.qian <shane.qian@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants