Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suddenly broken autocommands #13913

Closed
chdiza opened this issue Jan 24, 2024 · 4 comments · Fixed by neovim/neovim#27208
Closed

Suddenly broken autocommands #13913

chdiza opened this issue Jan 24, 2024 · 4 comments · Fixed by neovim/neovim#27208

Comments

@chdiza
Copy link

chdiza commented Jan 24, 2024

Steps to reproduce

Start vim and set &ft to mail. Observe:

Error detected while processing FileType Autocommands for "*"..Syntax Autocommands for
 "*"..Syntax Autocommands for "*"..function <SNR>4_SynSet[25]..script /pathtovimruntime/share/vim/vim91/syntax/mail.vim:
line   67:
E945: Range too large in character class
Press ENTER or type command to continue

Expected behaviour

I expect that not to happen. This just started after a fresh build, so the bad commit happened within the last couple of days. I'm at work and don't have time to bisect right now.

Version of Vim

9.1.50

Environment

Linux Mint 21.something

Logs and stack traces

No response

@chdiza chdiza added the bug label Jan 24, 2024
@chdiza
Copy link
Author

chdiza commented Jan 24, 2024

Have to be away from machine for a while, but I've discovered that having se re=1 in my vimrc is a necessary condition of this happening.

@chrisbra
Copy link
Member

chrisbra commented Jan 24, 2024

Yeah, it comes from this commit: 36e2c0f I'll ping the maintainer to add \%#=2 at the beginning of that particular syntax match. (although I am not really sure, that the DFA regex engine can handle such a large range in a collection).

@chdiza
Copy link
Author

chdiza commented Jan 24, 2024

OK, thanks. That is indeed the commit. I tested your suggested fix and it seems to work.

Separately, it's not clear to me why that commit messed with so many of the :hi colors. Is there a good reason for this?

@gi1242
Copy link
Contributor

gi1242 commented Jan 25, 2024

I'll send a pull request with the fix shortly. I changed the default groups because I (finally) moved to newer color schemes. Most of them seem to dim comments, so it made more sense to highlight signatures as comments instead of quoted texts.

gi1242 pushed a commit to gi1242/vim that referenced this issue Jan 25, 2024
gi1242 pushed a commit to gi1242/vim that referenced this issue Jan 25, 2024
clason added a commit to clason/neovim that referenced this issue Jan 26, 2024
runtime(mail): fix vim/vim#13913 (vim/vim#13917)

switch to the DFA engine for the emoji collaction range

vim/vim@046a0f7

Co-authored-by: gi1242 <gi1242+github@gmail.com>
Co-authored-by: GI <gi1242+vim@gmail.com>
clason added a commit to neovim/neovim that referenced this issue Jan 26, 2024
runtime(mail): fix vim/vim#13913 (vim/vim#13917)

switch to the DFA engine for the emoji collaction range

vim/vim@046a0f7

Co-authored-by: gi1242 <gi1242+github@gmail.com>
Co-authored-by: GI <gi1242+vim@gmail.com>
altermo pushed a commit to altermo/neovim-fork that referenced this issue Jan 26, 2024
runtime(mail): fix vim/vim#13913 (vim/vim#13917)

switch to the DFA engine for the emoji collaction range

vim/vim@046a0f7

Co-authored-by: gi1242 <gi1242+github@gmail.com>
Co-authored-by: GI <gi1242+vim@gmail.com>
altermo pushed a commit to altermo/neovim-fork that referenced this issue Jan 26, 2024
runtime(mail): fix vim/vim#13913 (vim/vim#13917)

switch to the DFA engine for the emoji collaction range

vim/vim@046a0f7

Co-authored-by: gi1242 <gi1242+github@gmail.com>
Co-authored-by: GI <gi1242+vim@gmail.com>
glepnir pushed a commit to glepnir/neovim that referenced this issue Mar 31, 2024
runtime(mail): fix vim/vim#13913 (vim/vim#13917)

switch to the DFA engine for the emoji collaction range

vim/vim@046a0f7

Co-authored-by: gi1242 <gi1242+github@gmail.com>
Co-authored-by: GI <gi1242+vim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants