Convert to addon v2 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
suggested changes
Mar 4, 2022
|
@AnastasiiaPlutalova @villander as I follow up, I suggest to add |
AnastasiiaPlutalova
force-pushed
the
convert_to_v2_part_4
branch
from
aed5c0a to
1cc356c
Compare
villander
requested changes
Mar 5, 2022
| @@ -27,11 +39,15 @@ | |||
| "lint:js:fix": "eslint . --fix" | |||
| }, | |||
| "dependencies": { | |||
| "ember-cli-babel": "^7.26.10" | |||
There was a problem hiding this comment.
No, according to tutorial part 4 step 3 https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md#part-4-convert-addon-to-v2
AnastasiiaPlutalova
force-pushed
the
convert_to_v2_part_4
branch
2 times, most recently
from
f8cd79f to
b088eba
Compare
SergeAstapov
approved these changes
Mar 9, 2022
test-app/package.json
Outdated
| @@ -90,5 +90,10 @@ | |||
| }, | |||
| "ember": { | |||
| "edition": "octane" | |||
| }, | |||
| "ember-addon": { | |||
There was a problem hiding this comment.
@AnastasiiaPlutalova I don't think we need this
AnastasiiaPlutalova
force-pushed
the
convert_to_v2_part_4
branch
from
b088eba to
b2c8dd6
Compare
villander
approved these changes
Mar 24, 2022
villander
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.