-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @ in resolved redirect URLs #1347
Comments
Fix pre-released as
I'm glad you're enjoying it. Would your company be up for sponsoring? |
Thank you so much! Re: sponsoring, yes, absolutely, assuming we end up using the site that I've built with Vike. I have put a calendar reminder on myself for next week to confirm, at which point I will sponsor if we are indeed using it by then. If not, I'll probably sponsor it personally. |
Thank you Quinn. We're beyond thrilled by the prospect of being sponsored by Sourcegraph. Fingers crossed 🤞
Let us know if you stumble upon any other blockers. |
Description
My intent is for Vike to redirect
/npm/*
tohttps://cdn.jsdelivr.net/npm/*
, but this breaks when the*
parameter matches something containing@
. This is common in this use case because the*
is matching npm package names (eg@my-team/my-package
).I see that
resolveRouteStringRedirect
forbids resolved URLs in redirection that contain@
. Is that restriction necessary?My vite.config.ts is:
I get the following error:
It works if I
throw redirect(...)
in an+onBeforeRender.ts
file, but I would prefer to specify it in config (because, and this might be a misperception, that then it will actually redirect at the HTTP layer even in static page hosts).p.s. Thank you for Vike! It is awesome.
The text was updated successfully, but these errors were encountered: