fix: update react-streaming (#1733)

vikejs · Jul 6, 2024 · c638d40 · c638d40
1 parent 598a3a2
commit c638d40
Show file tree

Hide file tree

Showing 10 changed files with 36 additions and 60 deletions.
diff --git a/examples/cloudflare-workers-react-full/package.json b/examples/cloudflare-workers-react-full/package.json
@@ -12,7 +12,7 @@
     "node-fetch": "^2.6.9",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "vite": "^5.0.10",
     "vike": "0.4.178",
     "wrangler": "^2.9.1"

diff --git a/examples/react-full/package.json b/examples/react-full/package.json
@@ -17,7 +17,7 @@
     "node-fetch": "^3.3.2",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "typescript": "^5.3.3",
     "vike": "0.4.178",
     "vite": "^5.2.11"

diff --git a/examples/react-streaming/package.json b/examples/react-streaming/package.json
@@ -14,7 +14,7 @@
     "express": "^4.18.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "sirv": "^2.0.2",
     "vite": "^5.0.10",
     "vike": "0.4.178"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test-deprecated-design/cloudflare-workers-react-full/package.json b/test-deprecated-design/cloudflare-workers-react-full/package.json
@@ -12,7 +12,7 @@
     "node-fetch": "^2.6.9",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "vite": "^5.0.10",
     "vike": "0.4.178",
     "wrangler": "^2.9.1"

diff --git a/test-deprecated-design/react-full/package.json b/test-deprecated-design/react-full/package.json
@@ -17,7 +17,7 @@
     "node-fetch": "^2.6.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "typescript": "^4.8.4",
     "vite": "^5.0.10",
     "vike": "0.4.178"

diff --git a/test-deprecated-design/react-streaming/package.json b/test-deprecated-design/react-streaming/package.json
@@ -13,7 +13,7 @@
     "express": "^4.18.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "sirv": "^2.0.2",
     "vite": "^5.0.10",
     "vike": "0.4.178"

diff --git a/vike/node/runtime/html/injectAssets.ts b/vike/node/runtime/html/injectAssets.ts
@@ -63,7 +63,7 @@ function injectHtmlTagsToStream(
 
     let htmlBegin = htmlPartsToString(htmlPartsBegin, pageAssets)
     htmlBegin = injectToHtmlBegin(htmlBegin, htmlTags)
-    await injectHtmlTagsUsingStream(htmlTags, streamFromReactStreamingPackage)
+    injectHtmlTagsUsingStream(htmlTags, streamFromReactStreamingPackage)
 
     return htmlBegin
   }

diff --git a/vike/node/runtime/html/injectAssets/injectHtmlTags.ts b/vike/node/runtime/html/injectAssets/injectHtmlTags.ts
@@ -21,15 +21,15 @@ function injectHtmlTags(htmlString: string, htmlTags: HtmlTag[], position: Posit
   return htmlString
 }
 
-async function injectHtmlTagsUsingStream(
+function injectHtmlTagsUsingStream(
   htmlTags: HtmlTag[],
   streamFromReactStreamingPackage: null | StreamFromReactStreamingPackage
-): Promise<void> {
+): void {
   const htmlFragment = joinHtmlTags(htmlTags.filter((h) => h.position === 'STREAM'))
   if (htmlFragment) {
     assert(streamFromReactStreamingPackage)
     assert(!streamFromReactStreamingPackage.hasStreamEnded())
-    await streamFromReactStreamingPackage.injectToStream(htmlFragment, { flush: true })
+    streamFromReactStreamingPackage.injectToStream(htmlFragment, { flush: true })
   }
 }
 

diff --git a/vike/package.json b/vike/package.json
@@ -138,7 +138,7 @@
     }
   },
   "peerDependencies": {
-    "react-streaming": ">=0.3.40",
+    "react-streaming": ">=0.3.41",
     "vite": ">=4.4.0"
   },
   "peerDependenciesMeta": {
@@ -209,7 +209,7 @@
     "es-module-lexer": "^1.4.1",
     "esbuild": "^0.19.10",
     "fast-glob": "^3.3.2",
-    "react-streaming": "^0.3.40",
+    "react-streaming": "^0.3.41",
     "rimraf": "^5.0.5",
     "sirv": "^2.0.4",
     "source-map-support": "^0.5.21",