fix: don't skip invalid URL but throw error instead

vikejs · Sep 4, 2024 · 2800dff · 2800dff
1 parent fe38737
commit 2800dff
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/vike/node/runtime/renderPage.ts b/vike/node/runtime/renderPage.ts
@@ -91,6 +91,7 @@ async function renderPage<
   assertArguments(...arguments)
   assert(hasProp(pageContextInit, 'urlOriginal', 'string')) // assertUsage() already implemented at assertArguments()
   assertEnv()
+  assertIsUrl(pageContextInit.urlOriginal)
   assertIsNotViteRequest(pageContextInit.urlOriginal)
 
   if (isIgnoredUrl(pageContextInit.urlOriginal)) {
@@ -474,7 +475,15 @@ function getRequestId(): number {
 }
 
 function isIgnoredUrl(urlOriginal: string): boolean {
-  return urlOriginal.endsWith('/favicon.ico') || !isUrl(urlOriginal)
+  return urlOriginal.endsWith('/favicon.ico')
+}
+function assertIsUrl(urlOriginal: string) {
+  assertUsage(
+    isUrl(urlOriginal),
+    `${pc.code('renderPage(pageContextInit)')} (https://vike.dev/renderPage) called with ${pc.code(
+      `pageContextInit.urlOriginal===${JSON.stringify(urlOriginal)}`
+    )} which isn't a valid URL`
+  )
 }
 function assertIsNotViteRequest(urlOriginal: string) {
   const isViteRequest =