-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hosting / AWS Lambda / Serverless Framework #338
Conversation
@magne4000 Thank you for your Feedback - do you need more changes? |
I have a question related to the template functions |
I created a new
I don't think so. I just need to try it out before merging :) |
How to run a specific |
@aheissenberger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not comment on each code related to Sentry, but the goal is to have Sentry code related to itself in its own sentry
boilerplate.
We should be able to integrate Sentry independently from serverless if needed.
@magne4000 the problem with the e2e test failing sometimes but not allways is not related to this changes |
Yes it sometimes happens due to some temp files being created, I usually just rerun the test manually. |
@@ -12,5 +19,41 @@ export default async function getViteConfig(props: TransformerProps) { | |||
options: reactOptions, | |||
}); | |||
|
|||
if (props.meta.BATI.has("sentry")) { | |||
// load app level environment variables from `.env` file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magne4000 I currently stuck with transforming existing vite.config code. Have a look at my code maybe you can help me to solve this.
An alternative solution would be, that the wrapper exists in the default function. I had to change the exports in packages/core/src/magicast.ts
to access the needed functions to manipulate the AST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change the exports in
packages/core/src/magicast.ts
to access the needed functions to manipulate the AST.
👍 no issue with that
An alternative solution would be, that the wrapper exists in the default function
I already tried that, but magicast
doesn't support this syntax sadly, so even if you could generate one, further $vite.config.ts.ts
wouldn't be able to parse it.
When faced with the same problem last time, my solution was to use process.ENV
instead of mode
so I can avoid creating the function.
Then complex manipulations where directly done in original vite.config.ts
.
@aheissenberger Please be sure to toggle this PR back to "Ready for review" once you consider I can review it again and test it. |
I have restarted with this:
How would you suggest to modle this requirement:
My current idea is:
|
With Universal Middleware directly supporting AWS Lambda there would be no need to add one of the serverless server frameworks like hono or hattip. |
If possible, we just edit
Same as above, choose one for now. This adds a lot of complexity to supports multiple of those I feel.
My goal is to have features with options soon for this kind of use cases. Usage would be: |
It will not be straightforward to implement (in |
#335
currently supports:
dist/client/assets
/assets
to the s3 bucket and all other requests to the lambda