Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ts-rest #269

Merged
merged 17 commits into from
Jun 19, 2024
Merged

feat: ts-rest #269

merged 17 commits into from
Jun 19, 2024

Conversation

phonzammi
Copy link
Member

@phonzammi phonzammi commented Jun 14, 2024 •
edited
Loading

@magne4000

Lets add ts-rest integration into Bati. Please help me resolve this feature.

  • ts-rest boilerplate
  • e2e test
  1. Servers integration :
  • express
  • fastify
  • h3
  • hono
  • hattip
  1. Clients integration :
  • react
  • solid
  • vue

@phonzammi
Copy link
Member Author

@magne4000
I'm happy with this PR.
Please take a look and review it.
Please share any suggestions you have for improvement.

@phonzammi phonzammi marked this pull request as ready for review June 18, 2024 05:40
magne4000
magne4000 requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@magne4000 magne4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had hope that we could reuse more code when using their exported adapters, but it's not the case 😞

@magne4000 magne4000 merged commit 95230a9 into vikejs:main Jun 19, 2024
8 checks passed
@phonzammi phonzammi deleted the feat-ts-rest branch June 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magne4000 magne4000 magne4000 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phonzammi @magne4000