-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:drizzle #258
feat:drizzle #258
Conversation
I would add a README with:
The other cool thing would be to adapt the default TODO examples, let me explain. What do you think? |
Sure, I'll do it later. There are more things I'll need to add.
I'm planning to add
We don't need to do What do you think ? |
I agree, let's do that 👍 |
You can see that a things have been moved around a lot 😅 Now, Todo is always present, with a default "database" using lowdb if none was selected. One last thing remains: proper E2E tests. All db + data fetching tests have been moved to On last few Bati's updates, I added support for happy-dom environment in tests, which allows us to simulate real user interactions in the UI. You can take a look at What I would to do is to remove the
@phonzammi Can I let you finish implementing those tests? I know there has been a lot of changes, so do not hesitate to ask me anything if something isn't clear. PS: we might need to extend tests timeouts quite a bit because files are getting quite big |
@magne4000, Thank you so much, your changes are awesome. I really appreciate that. I'm sorry I couldn't resolve all of your reviews, and I apologize for the number of commits this pull request required from me. 😄. I'm okay if you need to squash them, (FYI, I've never squashed commits before.)
Of course, I would like to try it. Thanks for letting me implement it. And let me know if it took too long for me to implement it. |
As discussed on Discord, we are currently blocked by |
@magne4000
Let me try to integrate Drizzle ORM into Bati. Please help me resolve this feature.
FYI, I've added ERROR_DRIZZLE_R_SERVER to the rules. Drizzle ORM is primarily designed to be used on the server side.