-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve temp filename generation #3
base: master
Are you sure you want to change the base?
Improve temp filename generation #3
Conversation
Prevent validator from stopping when URIs with get parameters are validated
Thanks for the contribution Marius, can you please elaborate on this particular change as I am not able to understand the reason for this change because ideally this is just the temp file name? |
The problem with those filenames is that there is some kind of caching mechanism so when a URL is validated successful the folowing URLs are not validated or considered as validated successful. This problem only occurs when you try to validate URLs with a GET-Parameters. |
Same issue here. Would be nice if you can accept the pr. |
Hi @webfeature, Thanks for reaching out, just to update that I have already taken care for removing all the special characters along with protocol from the file name. Latest version shouldn't have any issue wrt special characters, if you are facing some other issue then please let me know. In the current version the only difference in the file name from what @mariusbuescher requested as part of his changes is that file name will not be generated with whole URL and it will be taken only from last 2 values separated by "/" in URL and it can be anything. Rest all changes from @mariusbuescher has been taken into consideration. Why we have done this is because sometime URL can be too long and a very lengthy name can be a problematic to be used on Windows machines. Please let me know if this doesn't work and you expect the file name to be generated from whole URL. |
Can I close the request if the intended behavior is achieved in the latest plug-in as I have achieved what you were expecting in latest version of plug-in with just some changes? Thanks for your support and let me know if you have more feedback/comments. Thanks |
Hi vikash-bhardwaj, in the latest version i still facing the same problem. This is the setup:
In this case url_tempvlidation.html is created for the first file. The second remote file is skipped, because thr url_tempvlidation.html file already exists. |
Hey Marius, Thanks for the data I will take this up tomorrow or please send me a fresh Thanks for your contribution man!! Thanks On Mon, Aug 31, 2015 at 9:22 PM, webfeature notifications@github.com
|
Hi, Vikash! Just wanted to make you aware of two errata in the documentation for this plugin:
Thanks for your time and help. Warm regards, Chris |
Hi Chris, Thanks for the catch and I have published the new plug-in with some fixes I hope this helps and thanks for highlighting this. Regards On Thu, Sep 3, 2015 at 12:05 PM, Christopher Zenner <
|
Hi @webfeature, With the data you provided actually there were issues because plug-in was Please test your scenario and let me know if you still face issue with Thanks again for highlighting this. Vikash On Tue, Sep 1, 2015 at 9:25 PM, Vikash Bhardwaj vikasbhardwaj7@gmail.com
|
Hi Vikash, it's working now. Thank you for your support. But i think it is not working in every scenario correctly:
When i remove the I think, it should exist an option for ignoring the Best regards, |
@webfeature - I have tried to run with Error free files in between on files with errors and for me test run every time, it doesn't skip or break for me. Can you please confirm if you testing remote URLs or local files, I have tested with local files and I am not able to reproduce it? Regards |
Hi Vikash, i tested it with remote files. Sorry for the incomplete description of the problem. Regrads, |
can you please provide the test data which you tested or I can take any On Sat, Sep 5, 2015 at 4:04 PM, webfeature notifications@github.com wrote:
|
@webfeature, I tested the above given scenario for Remote configurations as well but couldn't reproduce the problem. Validator validate the URLs overtime even if there are files with no errors in between, it doesn't skip the URLs later after error free file. Please let me know if there is some very specific scenario that I have to look into. Thanks |
Hi Vikash, it's the same configuration as above with the Step 1 (everthing works fine):
Step 2 (page with id=8 is now valid, but it still includes error of Step 1):
Step 3 (validation is skipped, but it still includes error of Step 1):
Between each step i execute Config:
If i delete Regards, |
Hi Christian, Thanks for the update and It will be very helpful if you can send me the local package of your files if possible else I will create the data over the week-end. Thanks |
Hi Vikash, here a configuration which produce the error:
With the relaxerror option i simulate that the files ( Regards, |
Prevent validator from stopping when URIs with get parameters are validated. Temporary filename is generated in another way.