Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get more information about userBrowser #7

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Add function to get more information about userBrowser #7

merged 4 commits into from
Oct 14, 2022

Conversation

vuquangpham
Copy link
Contributor

No description provided.

@vuquangpham vuquangpham self-assigned this Oct 13, 2022
@netlify
Copy link

netlify bot commented Oct 13, 2022 •
edited
Loading

✅ Deploy Preview for fdebug ready!

Name Link
🔨 Latest commit 265d574
🔍 Latest deploy log https://app.netlify.com/sites/fdebug/deploys/6348db4a9df5ae0008f94e61
😎 Deploy Preview https://deploy-preview-7--fdebug.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vuquangpham vuquangpham added the enhancement New feature or request label Oct 13, 2022
@vuquangpham vuquangpham linked an issue Oct 13, 2022 that may be closed by this pull request
Add more info about user browser #2
Closed
4 tasks
@phucbm
Copy link
Member

phucbm commented Oct 13, 2022

Please change the display like this:

View: Body class, HTML class

Also, I don't want the underline here.

Screen Shot 2022-10-13 at 16 20 44

@vuquangpham vuquangpham mentioned this pull request Oct 13, 2022
Merged
@vuquangpham
Copy link
Contributor Author

Please change the display like this:

View: Body class, HTML class

Also, I don't want the underline here.

Screen Shot 2022-10-13 at 16 20 44

I have changed the style. Please check it again. Thanks !

@vuquangpham
Copy link
Contributor Author

I have chosen the ipify API because:

  • It's an open-source repository
  • No limit requests per minute
  • Its GitHub has more stars (over 1.3K)

phucbm
phucbm approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phucbm phucbm merged commit 6c7dfc6 into main Oct 14, 2022
@phucbm phucbm deleted the UserBrowser branch October 14, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phucbm phucbm phucbm approved these changes

Assignees

@vuquangpham vuquangpham

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more info about user browser
2 participants
@vuquangpham @phucbm