Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time feature for FE Debug #6

Merged
merged 9 commits into from
Oct 14, 2022
Merged

Add time feature for FE Debug #6

merged 9 commits into from
Oct 14, 2022

Conversation

vuquangpham
Copy link
Contributor

No description provided.

@vuquangpham vuquangpham added the enhancement New feature or request label Oct 7, 2022
@vuquangpham vuquangpham self-assigned this Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for fdebug ready!

⚠️ Warning: This private, organization-owned GitHub repository will require a Netlify Pro plan to deploy after the week of October 3rd, 2022. For more information, visit the deploy log and FAQ page.

Name Link
🔨 Latest commit 72ed283
🔍 Latest deploy log https://app.netlify.com/sites/fdebug/deploys/634008b2e5ab7300088295ed
😎 Deploy Preview https://deploy-preview-6--fdebug.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vuquangpham vuquangpham linked an issue Oct 7, 2022 that may be closed by this pull request
2 tasks
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for fdebug ready!

Name Link
🔨 Latest commit cd5307c
🔍 Latest deploy log https://app.netlify.com/sites/fdebug/deploys/6347e33534dabd0008144a05
😎 Deploy Preview https://deploy-preview-6--fdebug.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phucbm phucbm self-requested a review October 11, 2022 06:50
@vuquangpham
Copy link
Contributor Author

More information about the upTime feature:

  • The upTime script only runs when you turn on the debug on your website (like the way FEDebug works)
  • You can go all the pages of your website (through pathName)
  • I have checked the same website (to calculate the total time for accessing the page) by comparing the origin property (image below)

image

image

And that's all. So if you have a better way to make it, please let me know. Many thanks!

@phucbm
Copy link
Member

phucbm commented Oct 13, 2022

The Uptime is good now, but we need to know "time on this page" too. Something like this:

Uptime: (total)
On this page: ...

Thanks.

@vuquangpham
Copy link
Contributor Author

The Uptime is good now, but we need to know "time on this page" too. Something like this:

Uptime: (total) On this page: ...

Thanks.

I have added time on particular page features. Please check it again!

Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phucbm phucbm merged commit d08356f into main Oct 14, 2022
@phucbm phucbm deleted the time branch October 14, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add time on page
2 participants