Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#104] Check if we are in dev mode on post install script #110

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

nathan-schmidt-viget
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget commented Jun 14, 2024

Summary

Ran into this when Nevin was setting up the deploy script. When Github trys to deploy to a server like WP Engine it tries to set up DDEV for local development of which it fails and then the whole deploy script fails.
Nevin created a fix for IAFFF. So bringing that fix over to the starter so we don't run into it again.

Issues

Testing Instructions

  1. Not really a way to test this, but the deployment now works on IAFFF.

@bd-viget
Copy link
Contributor

This is probably fine, I just need to see if I can figure out what isDevMode() does to have a better understanding of what's going on here.

@nathan-schmidt-viget nathan-schmidt-viget merged commit db1d42d into main Jun 27, 2024
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/104-deploy-script branch June 27, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants