Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Button Icons #105

Open
5 of 6 tasks
bd-viget opened this issue Jun 13, 2024 · 0 comments
Open
5 of 6 tasks

Updates to Button Icons #105

bd-viget opened this issue Jun 13, 2024 · 0 comments
Assignees
@bd-viget

Comments

@bd-viget
Copy link
Contributor

bd-viget commented Jun 13, 2024 •
edited
Loading

Summary

There are a few improvements we need to make to the Button Icons functionality:

  1. Fix issue where new build is required to see updated icons.
  2. Add support for Page Link, Custom Link, Home Link, and Category Link blocks (for Navigations)
  3. Add documentation in the ACF Blocks Toolkit README about using the plugin filters with examples.
  4. Store the customized version of the icons.json file in the wp-content/uploads directory for better host support.
  5. Convert button-icons.php file functions to use a Class instead.
  6. Test for any other performance optimizations
@bd-viget bd-viget self-assigned this Jun 13, 2024
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Fixes to filterable icons
66d6e33
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Added defaultLeft support
7c15195
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Dummy proof the icon filter
a3e8eb6
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Added ACF Blocks Toolkit README file
4f96ab4
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Added support for more block types
efd99b7
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Convert button icons file into class
80bfbfb
bd-viget added a commit that referenced this issue Jun 13, 2024
@bd-viget
[#105] Fixed weird issue
327c0ec
@bd-viget bd-viget mentioned this issue Jun 13, 2024
Merged
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Fixes to filterable icons
19bc88a
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Added defaultLeft support
8bdb800
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Dummy proof the icon filter
f145753
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Added ACF Blocks Toolkit README file
58b5342
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Added support for more block types
7fbafe2
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Convert button icons file into class
39862af
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Fixed weird issue
9f8e733
bd-viget added a commit that referenced this issue Jun 14, 2024
@bd-viget
[#105] Block Icons Enhancements (#106)
0847df9 
* [#105] Fixes to filterable icons

* [#105] Added defaultLeft support

* [#105] Dummy proof the icon filter

* [#105] Added ACF Blocks Toolkit README file

* [#105] Added support for more block types

* [#105] Convert button icons file into class

* [#105] Fixed weird issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bd-viget bd-viget

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bd-viget