[#2] postcss-pxtorem: use wildcard propList #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfenton
requested review from
joshuapease,
ekfuhrmann,
ten1seven,
JJimmyFlynn and
maxdmyers
joshuapease
approved these changes
May 16, 2024
| rootValue: 16, | ||
| unitPrecision: 5, | ||
| propList: ['*'], |
There was a problem hiding this comment.
Works for me!
What do you think about putting a comment like this? Just to make it easy for folks to know they can exclude specific CSS properties if they'd like.
// Use ! to not match a property. Example: ['*', '!letter-spacing']
There was a problem hiding this comment.
and/or a comment linking to https://www.npmjs.com/package/postcss-pxtorem
ten1seven
approved these changes
May 16, 2024
maxdmyers
approved these changes
May 16, 2024
JJimmyFlynn
approved these changes
May 16, 2024
ekfuhrmann
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use wildcard
propListin postcss-pxtorem config