Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump font awesome version #9

Closed
wants to merge 2 commits into from

Conversation

bobschi
Copy link
Contributor

@bobschi bobschi commented Jun 6, 2024

Hi @vidhill,

I need a newer version of Font Awesome Brands for work, so I decided to stop by and bump it's version. :)

Copy link
Owner

@vidhill vidhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a snafoo with the order merging, and got a merge conflict, so I included your changes on another PR: #11

@vidhill
Copy link
Owner

vidhill commented Jun 6, 2024

#9 (review)

@vidhill vidhill closed this Jun 6, 2024
@vidhill
Copy link
Owner

vidhill commented Jun 6, 2024

@bobschi thanks again,

New release with your changes published to npm
https://www.npmjs.com/package/@vidhill/fortawesome-brands-11ty-shortcode?activeTab=versions

@bobschi
Copy link
Contributor Author

bobschi commented Jun 7, 2024

I made a snafoo with the order merging, and got a merge conflict, so I included your changes on another PR: #11

I could have also left a note about the other changes. 🙈
Thanks a ton for your work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants