Race canplay event with a setTimeout. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some browsers, like firefox with MSE, canplay doesn't fire at the correct time. So, we need to race it against a setTimeout so that we would actually try to resume if canplay doesn't fire correctly. In the tryToResume function we then clear out the event handler and the timeout depending on which came back first.
| player.one('contentcanplay', tryToResume); | ||
| player.ads.tryToResumeTimeout = player.setTimeout(tryToResume, 2000); |
There was a problem hiding this comment.
I used 2 seconds here. I'm not sure what this should actually be.
There was a problem hiding this comment.
Probably should suffix this with an underscore so it's obvious it's an internal variable.
Also, that they clear each other out.
Add a test to make sure initial setTimeout for race is called.
|
One comment about variable naming but otherwise LGTM |
dmlap
added a commit
that referenced
this pull request
Dec 11, 2015
Race canplay event with a setTimeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some browsers, like firefox with MSE, canplay doesn't fire at the
correct time. So, we need to race it against a setTimeout so that we
would actually try to resume if canplay doesn't fire correctly.
In the tryToResume function we then clear out the event handler and the
timeout depending on which came back first.
Also, see videojs/videojs-contrib-hls#469