Be More Dry #134
Merged
Be More Dry #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }; | ||
|
|
||
| player.on(videoEvents, function(event) { |
There was a problem hiding this comment.
Can you still name this function redispatch?
misteroneill
force-pushed
the
be-more-dry
branch
2 times, most recently
from
87241ea
to
513966f
Compare
| }); | ||
| }; | ||
|
|
||
| player.on(videoEvents, function redispatch(event) { |
There was a problem hiding this comment.
I assume the redispatch function is the same just moved? The diff makes it a bit hard to see it fully/exactly.
There was a problem hiding this comment.
Yeah, it got moved to be an inline callback and the construction of the videoEvents was greatly simplified.
misteroneill
force-pushed
the
be-more-dry
branch
from
513966f
to
be236ee
Compare
| register(obj, events[i], handler); | ||
| } | ||
| break; | ||
| case '[object Object]': |
There was a problem hiding this comment.
were we ever even using this case in the code? This would be the only thing that possibly could break.
There was a problem hiding this comment.
No, I checked - only strings and arrays!
|
Adding |
|
Yeah, sorry about that. 😄 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dries up a lot of code that was old and no longer needed. It builds on #133.