Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add file size PR check #8714

Closed
wants to merge 5 commits into from

Conversation

mister-ben
Copy link
Contributor

Adds compressed-size-action on PRs to view the impact on file size.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.98%. Comparing base (cb76a24) to head (ac95d65).

❗ Current head ac95d65 differs from pull request most recent head 9e676ea. Consider uploading reports for the commit 9e676ea to get more accurate results

Files Patch % Lines
src/js/video.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8714      +/-   ##
==========================================
- Coverage   83.00%   82.98%   -0.02%     
==========================================
  Files         120      120              
  Lines        7998     8001       +3     
  Branches     1927     1927              
==========================================
+ Hits         6639     6640       +1     
- Misses       1359     1361       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben
Copy link
Contributor Author

Will revisit another time. The action doesn't seem to be able to add a comment to a PR from a fork, so the information is buried in the actions run log.

@mister-ben mister-ben closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant