-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(svg-icons): default icons color #8382
Conversation
Uses the same color as defined by the `color` property of the `video-js` class to apply to `svg icons` for easy customization - set `fill` property to `currentColor`
Codecov Report
@@ Coverage Diff @@
## main #8382 +/- ##
==========================================
+ Coverage 82.68% 82.69% +0.01%
==========================================
Files 113 113
Lines 7578 7578
Branches 1821 1821
==========================================
+ Hits 6266 6267 +1
+ Misses 1312 1311 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -11,7 +11,7 @@ | |||
background-repeat: no-repeat; | |||
background-position: center; | |||
|
|||
fill: #FFFFFF; | |||
fill: currentColor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong here and I haven't tested, but should this be currentcolor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentcolor_keyword
though, I think it's case-insensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wseymour15, @gkatsev thanks for the review!
Would you like me to adjust the value ? If it helps to make a decision, here's what the W3C says https://www.w3.org/TR/css-color-3/#currentcolor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always fun when docs conflict 😄 You can leave as is. No strong feelings after reading that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, interesting that mdn doesn't document it like the spec. I would always err on the side of the spec, if possible.
Description
Uses the same color as defined by the
color
property of thevideo-js
class to apply tosvg icons
for easy customization.Specific Changes proposed
fill
property tocurrentColor
Requirements Checklist