Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASS import #6293

Closed
wants to merge 1 commit into from
Closed

Fix SASS import #6293

wants to merge 1 commit into from

Conversation

rechl
Copy link

@rechl rechl commented Oct 30, 2019

Fixes #6195

Description

When compiling .scss with node-sass in an angular project. the compiler can not use the import.

So i would like to remove the relative import.

This issue appears since #6055
As an alternative couldn't we use this one?

@import "node_modules/videojs-font/scss/icons";

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Oct 30, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@rechl rechl closed this Oct 30, 2019
@tsi
Copy link
Contributor

tsi commented Nov 20, 2019

@sgotre why is this closed? is it fixed? we are experiencing a similar issue with 7.6.5/6

@rechl
Copy link
Author

rechl commented Nov 20, 2019

@tsi because it was a duplicate and the tests did not complete all green.
this issue had been discussed here #4076
and my PR seems to be incompatible with the authors build system dart-sass.

To get around this, we copied the problematic sass file into our project and fixed it there for us.

@tsi
Copy link
Contributor

tsi commented Nov 20, 2019

Tnx, I see, seems like this was fixed in 5.x and 6.x but not in master (7)
created a PR here #6326

@rechl
Copy link
Author

rechl commented Nov 20, 2019

@tsi i wasn't sure about the best solution and furthermore i found it a bit strange to rely on an "external" scss file. So maybe we could find a better/more stable solution which works with all build systems. This repo is getting a lot of PRs and it was easy to fix within our code... So i decided to close this PR in favor of others

@rechl rechl deleted the patch-2 branch November 20, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Videojs 7.6.0 with angular
2 participants