Change menu items to ARIA role of "menuitemradio" when only one item can be selected #5171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change menu items to ARIA role of "menuitemradio" when only one item can be selected can be selected (i.e. in the Captions, Subtitles, Descriptions, Chapters, Audio Tracks, and Rate menus). Fixes #5136.
Specific Changes proposed
Add an option of
multiSelectable
onMenuItem
component; iftrue
, the item is marked as a checkbox (role="menuitemcheckbox"
), otherwise the item is marked as a radio button (role="menuitemradio"
). All existing menu items, except the Captions Settings Menu, will be marked as radio buttons (the Settings Menu item hasrole="menuitem"
), as will any components which extend the existing components and don't set 'multiSelectable'.Requirements Checklist