-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable time tooltips entirely in IE8 #4029
Conversation
'playProgressBar' | ||
], | ||
barName: 'playProgressBar' | ||
}; | ||
|
||
if (!IE_VERSION || IE_VERSION > 8) { | ||
SeekBar.prototype.options_.children.push('mouseTimeDisplay'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we splice it in to maintain the ordering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment otherwise, LGTM
children: [ | ||
'timeTooltip' | ||
] | ||
children: IE_VERSION && IE_VERSION < 9 ? [] : ['timeTooltip'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want make this the same style as the other if check
Booting up IE8 to test, code looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on IE8, IE10, and Chrome. LGTM
Pretty self-explanatory. These are more trouble than they're worth for a browser we only semi-support.
There are also a few tiny code cleanup pieces in here. Nothing significant.
Requirements Checklist