-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined tracks control #4028
Combined tracks control #4028
Changes from 7 commits
72b4c45
cf36fc4
ce99947
6cd1fff
19d0091
2a57cc9
e876942
b77d2bc
b273528
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
WEBVTT | ||
|
||
00:00.700 --> 00:04.110 | ||
FR CAP Captions describe all relevant audio for the hearing impaired. | ||
FR CAP [ Heroic music playing for a seagull ] | ||
|
||
00:04.500 --> 00:05.000 | ||
FR CAP [ Splash!!! ] | ||
|
||
00:05.100 --> 00:06.000 | ||
FR CAP [ Sploosh!!! ] | ||
|
||
00:08.000 --> 00:09.225 | ||
FR CAP [ Splash...splash...splash splash splash ] | ||
|
||
00:10.525 --> 00:11.255 | ||
FR CAP [ Splash, Sploosh again ] | ||
|
||
00:13.500 --> 00:14.984 | ||
FR CAP Dolphin: eeeEEEEEeeee! | ||
|
||
00:14.984 --> 00:16.984 | ||
FR CAP Dolphin: Squawk! eeeEEE? | ||
|
||
00:25.000 --> 00:28.284 | ||
FR CAP [ A whole ton of splashes ] | ||
|
||
00:29.500 --> 00:31.000 | ||
FR CAP Mine. Mine. Mine. | ||
|
||
00:34.300 --> 00:36.000 | ||
FR CAP Shark: Chomp | ||
|
||
00:36.800 --> 00:37.900 | ||
FR CAP Shark: CHOMP!!! | ||
|
||
00:37.861 --> 00:41.193 | ||
FR CAP EEEEEEOOOOOOOOOOWHALENOISE | ||
|
||
00:42.593 --> 00:45.611 | ||
FR CAP [ BIG SPLASH ] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
WEBVTT | ||
|
||
00:00.700 --> 00:04.110 | ||
DE SUB Captions describe all relevant audio for the hearing impaired. | ||
DE SUB [ Heroic music playing for a seagull ] | ||
|
||
00:04.500 --> 00:05.000 | ||
DE SUB [ Splash!!! ] | ||
|
||
00:05.100 --> 00:06.000 | ||
DE SUB [ Sploosh!!! ] | ||
|
||
00:08.000 --> 00:09.225 | ||
DE SUB [ Splash...splash...splash splash splash ] | ||
|
||
00:10.525 --> 00:11.255 | ||
DE SUB [ Splash, Sploosh again ] | ||
|
||
00:13.500 --> 00:14.984 | ||
DE SUB Dolphin: eeeEEEEEeeee! | ||
|
||
00:14.984 --> 00:16.984 | ||
DE SUB Dolphin: Squawk! eeeEEE? | ||
|
||
00:25.000 --> 00:28.284 | ||
DE SUB [ A whole ton of splashes ] | ||
|
||
00:29.500 --> 00:31.000 | ||
DE SUB Mine. Mine. Mine. | ||
|
||
00:34.300 --> 00:36.000 | ||
DE SUB Shark: Chomp | ||
|
||
00:36.800 --> 00:37.900 | ||
DE SUB Shark: CHOMP!!! | ||
|
||
00:37.861 --> 00:41.193 | ||
DE SUB EEEEEEOOOOOOOOOOWHALENOISE | ||
|
||
00:42.593 --> 00:45.611 | ||
DE SUB [ BIG SPLASH ] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
WEBVTT | ||
|
||
00:00.700 --> 00:04.110 | ||
FR SUB Captions describe all relevant audio for the hearing impaired. | ||
FR SUB [ Heroic music playing for a seagull ] | ||
|
||
00:04.500 --> 00:05.000 | ||
FR SUB [ Splash!!! ] | ||
|
||
00:05.100 --> 00:06.000 | ||
FR SUB [ Sploosh!!! ] | ||
|
||
00:08.000 --> 00:09.225 | ||
FR SUB [ Splash...splash...splash splash splash ] | ||
|
||
00:10.525 --> 00:11.255 | ||
FR SUB [ Splash, Sploosh again ] | ||
|
||
00:13.500 --> 00:14.984 | ||
FR SUB Dolphin: eeeEEEEEeeee! | ||
|
||
00:14.984 --> 00:16.984 | ||
FR SUB Dolphin: Squawk! eeeEEE? | ||
|
||
00:25.000 --> 00:28.284 | ||
FR SUB [ A whole ton of splashes ] | ||
|
||
00:29.500 --> 00:31.000 | ||
FR SUB Mine. Mine. Mine. | ||
|
||
00:34.300 --> 00:36.000 | ||
FR SUB Shark: Chomp | ||
|
||
00:36.800 --> 00:37.900 | ||
FR SUB Shark: CHOMP!!! | ||
|
||
00:37.861 --> 00:41.193 | ||
FR SUB EEEEEEOOOOOOOOOOWHALENOISE | ||
|
||
00:42.593 --> 00:45.611 | ||
FR SUB [ BIG SPLASH ] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
<!DOCTYPE html> | ||
<html lang="en-GB"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<title>Video.js Sandbox</title> | ||
|
||
<!-- Add ES5 shim and sham for IE8 --> | ||
<script src="../build/temp/ie8/videojs-ie8.js"></script> | ||
|
||
<!-- Load the source files --> | ||
<link href="../build/temp/video-js.css" rel="stylesheet" type="text/css"> | ||
<script src="../build/temp/video.js"></script> | ||
<script src="../node_modules/videojs-flash/dist/videojs-flash.js"></script> | ||
|
||
<!-- Set the location of the flash SWF --> | ||
<script> | ||
videojs.options.flash.swf = '../build/temp/video-js.swf'; | ||
videojs.addLanguage('de', { | ||
'Captions settings': 'Amerikanisch', | ||
'Subtitles settings': 'Global' | ||
}); | ||
</script> | ||
<style> | ||
.video-js:lang(en-US) { | ||
border: 3px solid red; | ||
} | ||
.vjs-control:focus { | ||
box-shadow: inset 0 0 0 2px rgba(27,127,204,.8); | ||
outline: none; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<div style="background-color:#eee; border: 1px solid #777; padding: 10px; margin-bottom: 20px; font-size: .8em; line-height: 1.5em; font-family: Verdana, sans-serif;"> | ||
<p>You can use /sandbox/ for writing and testing your own code. Nothing in /sandbox/ will get checked into the repo, except files that end in .example (so don't edit or add those files). To get started make a copy of index.html.example and rename it to index.html.</p> | ||
<pre>cp sandbox/index.html.example sandbox/index.html</pre> | ||
<pre>npm run start</pre> | ||
<pre>open http://localhost:9999/sandbox/index.html</pre> | ||
</div> | ||
|
||
<video id="vid1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="264" poster="http://vjs.zencdn.net/v/oceans.png"> | ||
<source src="http://vjs.zencdn.net/v/oceans.mp4" type="video/mp4"> | ||
<source src="http://vjs.zencdn.net/v/oceans.webm" type="video/webm"> | ||
<source src="http://vjs.zencdn.net/v/oceans.ogv" type="video/ogg"> | ||
<track kind="captions" src="../docs/examples/shared/example-captions.vtt" srclang="en" label="English"></track><!-- Tracks need an ending tag thanks to IE9 --> | ||
<track kind="captions" src="../docs/examples/shared/example-captions-fr.vtt" srclang="fr" label="French"></track><!-- Tracks need an ending tag thanks to IE9 --> | ||
<track kind="subtitles" src="../docs/examples/shared/example-subtitles-fr.vtt" srclang="fr" label="French"></track><!-- Tracks need an ending tag thanks to IE9 --> | ||
<track kind="subtitles" src="../docs/examples/shared/example-subtitles-de.vtt" srclang="de" label="German"></track><!-- Tracks need an ending tag thanks to IE9 --> | ||
<p class="vjs-no-js">To view this video please enable JavaScript, and consider upgrading to a web browser that <a href="http://videojs.com/html5-video-support/" target="_blank">supports HTML5 video</a></p> | ||
</video> | ||
|
||
<script> | ||
var vid = document.getElementById("vid1"); | ||
var player = videojs(vid, { | ||
controlBar: { | ||
children: [ | ||
'playToggle', | ||
'volumePanel', | ||
'currentTimeDisplay', | ||
'timeDivider', | ||
'durationDisplay', | ||
'progressControl', | ||
'liveDisplay', | ||
'remainingTimeDisplay', | ||
'customControlSpacer', | ||
'playbackRateMenuButton', | ||
'chaptersButton', | ||
'descriptionsButton', | ||
'subtitlesButton', | ||
'captionsButton', | ||
'subsCapsButton', | ||
'audioTrackButton', | ||
'fullscreenToggle' | ||
] | ||
} | ||
}); | ||
console.log(player.language()); | ||
</script> | ||
|
||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// North America uses 'CC' icon | ||
.video-js:lang(en) .vjs-subs-caps-button .vjs-icon-placeholder, | ||
.video-js:lang(fr-CA) .vjs-subs-caps-button .vjs-icon-placeholder { | ||
@extend .vjs-icon-captions; | ||
} | ||
|
||
// ROW uses 'subtitles' | ||
// Double selector because @extend puts these rules above the captions icon | ||
.video-js .vjs-subs-caps-button .vjs-icon-placeholder, | ||
.video-js.video-js:lang(en-GB) .vjs-subs-caps-button .vjs-icon-placeholder, | ||
.video-js.video-js:lang(en-IE) .vjs-subs-caps-button .vjs-icon-placeholder, | ||
.video-js.video-js:lang(en-AU) .vjs-subs-caps-button .vjs-icon-placeholder, | ||
.video-js.video-js:lang(en-NZ) .vjs-subs-caps-button .vjs-icon-placeholder { | ||
@extend .vjs-icon-subtitles; | ||
} | ||
|
||
.video-js .vjs-subs-caps-button + .vjs-menu .vjs-captions-menu-item .vjs-menu-item-text:after { | ||
content: " \f10d"; | ||
font-family: VideoJS; | ||
vertical-align: bottom; | ||
font-size: 1.5em; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
/** | ||
* @file tracks-button.js | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just noticed - this file name needs updating. (<Captain Pedantic, at you're service ;-)>) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah yes. (Not rising to "you're"...) |
||
*/ | ||
import TextTrackButton from './text-track-button.js'; | ||
import Component from '../../component.js'; | ||
import CaptionSettingsMenuItem from './caption-settings-menu-item.js'; | ||
import toTitleCase from '../../utils/to-title-case.js'; | ||
/** | ||
* The button component for toggling and selecting captions | ||
* | ||
* @extends TextTrackButton | ||
*/ | ||
class SubsCapsButton extends TextTrackButton { | ||
|
||
constructor(player, options = {}) { | ||
super(player, options); | ||
|
||
// Although North America uses "captions" in most cases for | ||
// "captions and subtitles" other locales use "subtitles" | ||
this.label_ = 'subtitles'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need to be localized? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This gets concatenated into 'captions setttings' and 'captions off', which do get localised. |
||
if (['en', 'en-us', 'en-ca', 'fr-ca'].indexOf(this.player_.language_) > -1) { | ||
this.label_ = 'captions'; | ||
} | ||
this.menuButton_.controlText(toTitleCase(this.label_)); | ||
|
||
} | ||
|
||
/** | ||
* Builds the default DOM `className`. | ||
* | ||
* @return {string} | ||
* The DOM `className` for this object. | ||
*/ | ||
buildCSSClass() { | ||
return `vjs-subs-caps-button ${super.buildCSSClass()}`; | ||
} | ||
|
||
/** | ||
* Update caption menu items | ||
* | ||
* @param {EventTarget~Event} [event] | ||
* The `addtrack` or `removetrack` event that caused this function to be | ||
* called. | ||
* | ||
* @listens TextTrackList#addtrack | ||
* @listens TextTrackList#removetrack | ||
*/ | ||
update(event) { | ||
let threshold = 2; | ||
|
||
super.update(); | ||
|
||
// if native, then threshold is 1 because no settings button | ||
if (this.player().tech_ && this.player().tech_.featuresNativeTextTracks) { | ||
threshold = 1; | ||
} | ||
|
||
if (this.items && this.items.length > threshold) { | ||
this.show(); | ||
} else { | ||
this.hide(); | ||
} | ||
} | ||
|
||
/** | ||
* Create caption/subtitles menu items | ||
* | ||
* @return {CaptionSettingsMenuItem[]} | ||
* The array of current menu items. | ||
*/ | ||
createItems() { | ||
let items = []; | ||
|
||
if (!(this.player().tech_ && this.player().tech_.featuresNativeTextTracks)) { | ||
items.push(new CaptionSettingsMenuItem(this.player_, {kind: this.label_})); | ||
} | ||
|
||
items = super.createItems(items); | ||
return items; | ||
} | ||
|
||
} | ||
|
||
/** | ||
* `kind`s of TextTrack to look for to associate it with this menu. | ||
* | ||
* @type {array} | ||
* @private | ||
*/ | ||
SubsCapsButton.prototype.kinds_ = ['captions', 'subtitles']; | ||
|
||
/** | ||
* The text that should display over the `SubsCapsButton`s controls. | ||
* | ||
* | ||
* @type {string} | ||
* @private | ||
*/ | ||
SubsCapsButton.prototype.controlText_ = 'Subtitles'; | ||
|
||
Component.registerComponent('SubsCapsButton', SubsCapsButton); | ||
export default SubsCapsButton; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is showing up in the screen reader. We need to add an icon placeholder span.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @gkatsev !! I haven't had a chance to check this, but is there some
controlText
for the icon, so that something is read out by a screen reader instead of the icon? Otherwise, that's an #a11y violation too - information which is conveyed visually, but not to SR users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this can't be done with CSS alone in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't think this is possible to do in CSS. @mister-ben do you think you can get to it this week? Otherwise, I'm thinking we can merge it in as is and I or someone else can tackle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably won't have a chance to look at this now before the end of next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @mister-ben this is pretty awesome as it is. We'll take care of this final piece!