fix: remove unnecessary comments from video.min.js #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves updating to latest version of uglify and setting "screwIE8" to false since that is a default in 2.7. However, this makes "preserveComments" "some" work as it is supposed to work. Fixes #3707
|
I still need to verify that this works in IE8. |
Closed
|
Verified that it works in IE8. |
misteroneill
approved these changes
Oct 24, 2016
gkatsev
added a commit
to gkatsev/video.js
that referenced
this pull request
Oct 25, 2016
This involves updating to latest version of uglify and setting "screwIE8" to false since that is a default in 2.7. However, this makes "preserveComments" "some" work as it is supposed to work. Fixes videojs#3707. This also comes from the stable branch after the 5.11.9 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.
Fixes #3707