Add title to all clickable components #3296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| * @return {String} | ||
| * @method controlText | ||
| */ | ||
| controlText(text) { | ||
| controlText(text, el=this.el()) { |
There was a problem hiding this comment.
is it possible that this.el() will end up returning nothing?
There was a problem hiding this comment.
Only during the first call, because that is made from createEl, at which time this.el() does not eixst yet. Afterwards it should always exist, right?
|
LGTM. |
gkatsev
added
confirmed
minor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on Slack yesterday, this will add a
titleto all clickable components.I modified the play toggle test to also check for this, as this was the only test that seemed to test for this already.
Because
controlTextis already called increateElI had to pass the element to set the title on to the function.Specific Changes proposed
This sets the
titleHTML attribute on all clickable components when settingcontrolText_initially or changing it usingcontrolText(...).Requirements Checklist