Fix Captions Settings Dialog labeling for accessibility #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let template = ` | ||
| <div role="document"> | ||
| <h1 id="${dialogLabelId}" class="vjs-control-text">Captions Settings Dialog</h1> |
There was a problem hiding this comment.
We probably should use a div here instead of h1, I had to change the elements used in videojs-dock because websites often style h1 elements and it broke the title and descriptions of the plugin
There was a problem hiding this comment.
Even though class="vjs-control-text" means this one is visually hidden, and just there for Screen Readers?
There was a problem hiding this comment.
Ah, right, I guess that's fine then.
gkatsev
added
minor
|
Hey, @OwenEdwards any updates on this one? Thoughts on my latest comment? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #3054, this PR fixes screen reader labeling of the Captions Settings Dialog. This fixes point 1 of #2746.
Specific Changes proposed
Add fieldsets & legends, and off-screen text for labels. Also, remove the '---' values.
Requirements Checklist