Add <style> to player tag instead of head #3240
Conversation
|
Thank you for the PR; unfortunately, we cannot accept it. We used to have this in the player but we got rid of it. The reason why we cannot have it be inside the player element is that then it's really hard to override the player css. However, one thing you should take a look at -- which will be released as 5.9.0 later today -- is the Thanks, hope to see more from you! |
|
Ah indeed, I can understand the specificity problem. I think scoped is probably going to be dropped from the spec too, as Firefox is the only browser to implement it and Blink have performance/optimisation concerns. In the distant future this would probably be better handled using a shadow tree anyway. Thanks for pointing me towards VIDEOJS_NO_DYNAMIC_STYLE 😄. |
|
No problem, it just got added and released as part of 5.9. |
Description
Another portability fix (see #3230). Currently, players moved to or created in a different window from the video.js script will not have the proper dimensions applied.
Specific Changes proposed
The video dimensions stylesheet is added to the player element instead of
<head>. Thescopedattribute is also set, though only supported by Firefox it also serves as a cosmetic validation for where the element is contained (scoped style elements are permitted alongside flow content).By doing this, the element can be moved to another window or frame without losing these dimensions. All browsers support
<style>elements outside of<head>, though it is technically invalid without thescopedattribute. Behaviour-wise, nothing has changed so current tests continue to pass and additional unit tests are unnecessary.Requirements Checklist